Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: optimize the store state filter metrics (#2946) #3100

Merged
merged 3 commits into from
Jan 5, 2021
Merged

metrics: optimize the store state filter metrics (#2946) #3100

merged 3 commits into from
Jan 5, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2946 to release-4.0

What problem does this PR solve?

Close #2933.

What is changed and how it works?

This PR records the detailed reason in the filter type. After this PR:
Screen Shot 2020-09-14 at 2 25 07 PM

Check List

Tests

  • Manual test

Release note

@ti-srebot ti-srebot mentioned this pull request Oct 26, 2020
Merged
@ti-srebot ti-srebot added component/metrics Metrics. status/LGT3 The PR has already had 3 LGTM. type/cherry-pick labels Oct 26, 2020
@ti-srebot ti-srebot added this to the v4.0.8 milestone Oct 26, 2020
@disksing
Copy link
Contributor

It looks like this cherry-pick comes with many other commits (some of them may include behaviour changes).

@HunDunDM HunDunDM modified the milestones: v4.0.8, v4.0.9 Oct 29, 2020
@tikv tikv deleted a comment from ti-srebot Nov 2, 2020
@tikv tikv deleted a comment from ti-chi-bot Nov 2, 2020
@tikv tikv deleted a comment from ti-srebot Nov 3, 2020
@tikv tikv deleted a comment from ti-chi-bot Nov 3, 2020
@AndreMouche
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

@AndreMouche: adding LGTM is restricted to reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@HunDunDM HunDunDM modified the milestones: v4.0.9, v4.0.10 Nov 25, 2020
@rleungx
cherry pick tikv#2946 to release-4.0 (tikv#3100)
627de36 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx removed the status/DNM label Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #3100 (cef4b09) into release-4.0 (703471b) will increase coverage by 0.33%.
The diff coverage is 82.75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3100      +/-   ##
===============================================
+ Coverage        74.77%   75.10%   +0.33%     
===============================================
  Files              209      209              
  Lines            19594    19621      +27     
===============================================
+ Hits             14651    14737      +86     
+ Misses            3617     3553      -64     
- Partials          1326     1331       +5
Flag Coverage Δ
unittests 75.10% <82.75%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/filter/filters.go 82.40% <75.60%> (-3.26%) ⬇️
server/schedule/checker/rule_checker.go 82.31% <100.00%> (ø)
server/schedule/operator/builder.go 92.57% <100.00%> (ø)
server/schedule/region_scatterer.go 84.13% <100.00%> (ø)
server/schedulers/adjacent_region.go 73.93% <100.00%> (ø)
server/schedulers/balance_leader.go 91.50% <100.00%> (ø)
server/schedulers/balance_region.go 84.80% <100.00%> (ø)
server/schedulers/evict_leader.go 68.71% <100.00%> (ø)
server/schedulers/hot_region.go 80.76% <100.00%> (ø)
server/schedulers/label.go 70.37% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703471b...cef4b09. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Dec 23, 2020

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

@nolouch: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@nolouch
Copy link
Contributor

nolouch commented Dec 23, 2020

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

@nolouch: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@HunDunDM
Copy link
Member

HunDunDM commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

@HunDunDM: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@HunDunDM HunDunDM added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT3 The PR has already had 3 LGTM. labels Jan 5, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cef4b09

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit e5be7fd into tikv:release-4.0 Jan 5, 2021
This was referenced Jan 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

@disksing disksing Awaiting requested review from disksing

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@rleungx rleungx

Labels
component/metrics Metrics. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.10
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @disksing @AndreMouche @ti-chi-bot @nolouch @HunDunDM @lhy1024 @rleungx